From 7a7af735ade0fc12ff413e2724ea4006d4c09691 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Tue, 14 Mar 2023 10:30:32 +0100 Subject: [PATCH] test/system/255-auto-update.bats: multiple services Wait for all generated services to be ready to be sure we can iron out race conditions. Also disable rollbacks to make sure we can analyze the error if restarting a service fails. This information may be crucial to understand the flakes on Debian as tracked in #17607. Signed-off-by: Valentin Rothberg --- test/system/255-auto-update.bats | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/system/255-auto-update.bats b/test/system/255-auto-update.bats index 12a6e5c5a7..b9ba7f2ca5 100644 --- a/test/system/255-auto-update.bats +++ b/test/system/255-auto-update.bats @@ -338,11 +338,13 @@ EOF fi done - # Only check that the last service is started. Previous services should already be activated. - _wait_service_ready container-$cname.service + # Make sure all services are ready. + for cname in "${cnames[@]}"; do + _wait_service_ready container-$cname.service + done run_podman commit --change CMD=/bin/bash $local_cname quay.io/libpod/localtest:latest # Exit code is expected, due to invalid 'fakevalue' - run_podman 125 auto-update + run_podman 125 auto-update --rollback=false update_log=$output is "$update_log" ".*invalid auto-update policy.*" "invalid policy setup" is "$update_log" ".*Error: invalid auto-update policy.*" "invalid policy setup"