From 0115a4800b1930cc8fd88317f9bef3bbca8ee1f9 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Thu, 6 Jul 2023 15:12:12 +0200 Subject: [PATCH] CI: remove build without cgo task Podman is basically unusable without cgo, checking if it compiles without adds no value and just tricks people into thinking it works when it does not. This means we do not need extra to NOP out a lot of cgo calls with functions that just return an error like `XXX is not supported without cgo`. Signed-off-by: Paul Holzinger --- .cirrus.yml | 2 -- Makefile | 7 ------- contrib/cirrus/runner.sh | 3 --- 3 files changed, 12 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 6bdeafe3a4..52c39d5965 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -379,8 +379,6 @@ alt_build_task: ALT_NAME: 'Build Each Commit' - env: ALT_NAME: 'Windows Cross' - - env: - ALT_NAME: 'Build Without CGO' - env: ALT_NAME: 'Alt Arch. Cross' - env: diff --git a/Makefile b/Makefile index 812a3fc01f..8e701c37cb 100644 --- a/Makefile +++ b/Makefile @@ -446,13 +446,6 @@ local-cross: $(CROSS_BUILD_TARGETS) ## Cross compile podman binary for multiple .PHONY: cross cross: local-cross -.PHONY: build-no-cgo -build-no-cgo: - BUILDTAGS="containers_image_openpgp exclude_graphdriver_btrfs \ - exclude_graphdriver_devicemapper exclude_disk_quota" \ - CGO_ENABLED=0 \ - $(MAKE) all - .PHONY: completions completions: podman podman-remote # key = shell, value = completion filename diff --git a/contrib/cirrus/runner.sh b/contrib/cirrus/runner.sh index 6594c57210..5e0f8357ef 100755 --- a/contrib/cirrus/runner.sh +++ b/contrib/cirrus/runner.sh @@ -276,9 +276,6 @@ function _run_altbuild() { make podman-remote-release-windows_amd64.zip make podman.msi ;; - *Without*) - make build-no-cgo - ;; *RPM*) make package ;;