Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model is being copied to podman machine twice when starting a recipe #1899

Closed
cbr7 opened this issue Oct 14, 2024 · 1 comment · Fixed by #2067
Closed

Model is being copied to podman machine twice when starting a recipe #1899

cbr7 opened this issue Oct 14, 2024 · 1 comment · Fixed by #2067
Assignees
Labels
kind/bug 🐞 Something isn't working

Comments

@cbr7
Copy link
Contributor

cbr7 commented Oct 14, 2024

Bug description

It seems that currently whenever an app is started the model is being copied to the podman machine twice. This was identified on a custom build of ai-lab with additional tracing.

Image

Operating system

windows

Installation Method

from ghcr.io/containers/podman-desktop-extension-ai-lab container image

Version

next (development version)

Steps to reproduce

No response

Relevant log output

No response

Additional context

No response

@cbr7 cbr7 added the kind/bug 🐞 Something isn't working label Oct 14, 2024
@cbr7 cbr7 moved this to 📋 Backlog in Podman Desktop Planning Oct 14, 2024
@axel7083
Copy link
Contributor

axel7083 commented Oct 14, 2024

We seems to have a duplicate call to the ModelsManager#uploadModelToPodmanMachine when we start a recipe

  1. First the ApplicationManager upload the model

const modelPath = await this.modelsManager.uploadModelToPodmanMachine(connection, model, {

  1. The the InferenceManager upload the model

this.modelsManager.uploadModelToPodmanMachine(connection, modelInfo, config.labels).then(path => ({

Technical debs

Since #1503 we mixed a lot of code between the ApplicationManager and the InferenceServer, by mixing runtime resources (pods, containers) and static resources (configuration yaml, models files).

We have an issue related to improving the architecture #1542

@jeffmaury jeffmaury self-assigned this Nov 7, 2024
@jeffmaury jeffmaury moved this from 📋 Backlog to 🚧 In Progress in Podman Desktop Planning Nov 7, 2024
@nichjones1 nichjones1 moved this to 🚧 In Progress in Podman Desktop Planning Nov 15, 2024
@jeffmaury jeffmaury moved this from 🚧 In Progress to 🚥 In Review in Podman Desktop Planning Nov 18, 2024
@github-project-automation github-project-automation bot moved this from 🚥 In Review to ✔️ Done in Podman Desktop Planning Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug 🐞 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants