Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macvlan needs to be able to do dhcp #152

Closed
baude opened this issue Jan 7, 2022 · 9 comments
Closed

macvlan needs to be able to do dhcp #152

baude opened this issue Jan 7, 2022 · 9 comments
Assignees

Comments

@baude
Copy link
Member

baude commented Jan 7, 2022

The e2e tests assume dhcp is available with macvlan.

Error: macvlan driver needs at least one subnet specified, DHCP is not supported with netavark

Example -> https://github.com/containers/podman/blob/main/test/e2e/network_test.go#L529

@Luap99
Copy link
Member

Luap99 commented Jan 8, 2022

DHCP support is complicated because it requires a daemon. I would say we should skip this for now.

@baude
Copy link
Member Author

baude commented Jan 10, 2022

lets keep our eye on this ... else it is a regression from cni

@Luap99
Copy link
Member

Luap99 commented Jan 10, 2022

Well it is not easy to implement and we have a lot of other things to do. The regression argument doesn't count IMO since we still support CNI for those who need it.

@flouthoc
Copy link
Collaborator

I accidentally attached this issue to wrong PR that's why it got closed. Thanks for re-opening.

@Jackbaude
Copy link

Can I take this one?

@baude
Copy link
Member Author

baude commented Mar 21, 2022

@Jackbaude we will send people running into the hills!

@Jackbaude
Copy link

Was there a DHCP crate that you had in mind?

@briankoco
Copy link

briankoco commented May 7, 2022

Expressing my desire for this feature. Macvlan is ideal for containerized deployments that you want to have access to a DHCP server on your physical network

@Jackbaude
Copy link

I have started a crate for the proxy daemon.

@baude baude closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants