Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout feature #162

Closed
npmccallum opened this issue May 27, 2020 · 2 comments
Closed

Timeout feature #162

npmccallum opened this issue May 27, 2020 · 2 comments

Comments

@npmccallum
Copy link

I'm looking for a timeout feature for conmon. Specifically, I want conmon to kill the container if it doesn't exit before a timeout period elapses.

Currently, conmon has a mostly undocumented command line option --timeout. It is not clear what this feature actually does. But I suspect that it just exits conmon after a period of time. It is not obvious to me that it actually kills the container at the timeout.

I'm not sure why it is useful to exit conmon at a timeout without killing the container. But would conmon consider a patch to kill the container at the timeout (either as the default behavior or behind another CLI option)?

@haircommander
Copy link
Collaborator

this timeout is used for the a detached exec, where conmon is expected to exit before any of the container logs are accessed. (ref)[https://github.com/cri-o/cri-o/blob/master/internal/oci/runtime_oci.go#L409]

the timeout does kill the container_pid ref, but, again, it's only used for an exec. I suppose it could time out after a create, but it would not be relative to the container start, because conmon runs the create then sits listening on sockets until the container exits.

I'm assuming you want the container to timeout after it starts, rather than after it was created (podman run == runc create + runc start). This seems more of podman job to me

@npmccallum
Copy link
Author

I'm assuming you want the container to timeout after it starts, rather than after it was created (podman run == runc create + runc start). This seems more of podman job to me

Correct. I've opened an issue with podman above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants