Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports for v0.44 (Podman v3.4) and cut v0.44.5 #959

Merged
merged 3 commits into from
Mar 13, 2022

Conversation

vrothberg
Copy link
Member

Changelog:

  • bump to v0.44.6-dev
  • v0.44.5
  • libimage: speed up image filters

Backporting fixes for containers/podman#11997

@containers/podman-maintainers @rhatdan PTAL

vrothberg and others added 3 commits March 11, 2022 13:14
With commit 86afb94 the dangling checks have been changed to be
compatible with Docker.  Since then, the dangling also need to compute
children.

Speed up the dangling and intermediate checks by computing the layer
tree *once* instead of for each filter invocation.

**Before:**
real    0m10.837s
user    0m11.308s
sys     0m4.231s

**After:**
real    0m0.476s
user    0m0.478s
sys     0m0.151s

Context: github.com/containers/podman/issues/11997
Signed-off-by: Valentin Rothberg <[email protected]>
* libimage: speed up image filters

Signed-off-by: Valentin Rothberg <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Mar 13, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit c65ec99 into containers:v0.44 Mar 13, 2022
@vrothberg vrothberg deleted the v0.44.5 branch March 14, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants