Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfraCommand should be []string not string #240

Closed
vrothberg opened this issue Jul 31, 2020 · 1 comment
Closed

InfraCommand should be []string not string #240

vrothberg opened this issue Jul 31, 2020 · 1 comment

Comments

@vrothberg
Copy link
Member

The InfraCommand should be a string slice. Limiting it to a single string excludes quite a some use cases where users want or need to specify arguments.

Not sure how to handle backwards compat.

@rhatdan @mheon @QiWang19 WDYT?

I was browsing through our stack while working on containers/podman#7167 and noticed the inconsistency of []string <-> string.
@vrothberg
Copy link
Member Author

Closing for now to keep the discussion in containers/podman#7167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vrothberg