Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindHelperBinary should support windows #1123

Closed
arixmkii opened this issue Aug 18, 2022 · 3 comments · Fixed by #1131
Closed

FindHelperBinary should support windows #1123

arixmkii opened this issue Aug 18, 2022 · 3 comments · Fixed by #1131

Comments

@arixmkii
Copy link
Contributor

Current implementation https://github.com/containers/common/blob/main/pkg/config/config.go#L1254 is oversimplified, when looking up binaries in the preconfigured paths. It should better match behavior of exec.LookPath which has dedicated

The main problem, that on windows you should try to look for files with various executable marking extensions in name. Current workaround is to provide full name with ".exe" for the lookup in windows specific paths, but it doesn't fix the root cause.

My proposal would be to take and modify for this specific need Go lang versions if there are no problems with licensing (haven't checked it yet).

If it is fine forking and including some sources from Go itself into this project, I can try making PR.

Was discovered making experiments with podman and qemu on windows: containers/podman#13006

@arixmkii
Copy link
Contributor Author

Another workaround is to rename gvproxy.exe to gvproxy (w/o extension on win machine). But it is better to have this fixed anyway.

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2022

Ok will you be preparing a patch?

@arixmkii
Copy link
Contributor Author

Will do it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants