repository name must be canonical when buildah is > 1.22.0

[rcny]

Description

buildah login docker.io/user errors with

parse reference from "docker.io/user": repository name must be canonical

after updating to 1.22.3 from 1.22.0. buildah login docker.io/user worked before, had to change to buildah login docker.io to make it work again.

Most possibly this behavior change was introduced here.

Steps to reproduce the issue:

1. Install buildah 1.22.3
2. echo "foobar" | buildah login --username "user" --password-stdin "docker.io/user" (use proper creds)

Describe the results you received:

parse reference from "docker.io/user": repository name must be canonical

Describe the results you expected:

Login Succeeded!

[vrothberg]

Thanks for reaching out, @rcny! @saschagrunert PTAL

[saschagrunert]

The issue is that docker.io/user will fail on ParseNamed() here:

buildah/vendor/github.com/containers/image/v5/docker/reference/reference.go

Lines 246 to 248 in 58a16f9

	if named.String() != s {
	return nil, ErrNameNotCanonical
	}

A valid input would be docker.io/library/user, which should work.

Working on a fix in containers/common#757

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[rhatdan]

@saschagrunert @mtrmac Where are we on this?

[saschagrunert]

@saschagrunert @mtrmac Where are we on this?

Coming back to this one, I think containers/common#763 is the right appraoch in replacement to containers/common#757

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[rhatdan]

I believe this is fixed now, closing. Reopen if I am mistaken.

[vrothberg]

It is not fixed, reopening. I really want this to work before we cut Podman 4.0.

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[vrothberg]

This has been fixed in the meantime.