Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

Please "vendor" released/tagged dependencies whenever possible #98

Closed
onlyjob opened this issue Nov 8, 2015 · 8 comments
Closed

Please "vendor" released/tagged dependencies whenever possible #98

onlyjob opened this issue Nov 8, 2015 · 8 comments

Comments

@onlyjob
Copy link

onlyjob commented Nov 8, 2015

Downstream package maintainers should be able to reuse packages that are usually built from released/tagged versions instead of random snapshot.

Whenever possible please bundle (vendor) released/tagged versions of components in Godeps. Thanks.

@jonboulle
Copy link
Contributor

I don't really understand your question - we do vendor dependencies right now https://github.com/appc/acbuild/blob/master/Godeps/Godeps.json - no?

@onlyjob
Copy link
Author

onlyjob commented Nov 8, 2015

Yes but bundled (vendored) version of github.com/appc/spec is ahead of latest release. Presumably releases are suppose to be API-stable so vendoring random snapshot of "master" is not nice.

@cgonyeo
Copy link
Member

cgonyeo commented Nov 8, 2015

This is something I'll be interested in enforcing once acbuild comes a little farther along.

At this point in time a lot of its core features are still being created, which often requires patches to its dependencies. I'd prefer to not have acbuild development blocking on new releases of the appc spec or rkt, but once things become more stable it should be reasonable to stick to tagged releases of dependencies.

@onlyjob
Copy link
Author

onlyjob commented Nov 8, 2015

Precisely. In this particular case I've noticed that acbuild v0.1.1 uses/requires unreleased snapshot of appc/spec which is not compatible with its latest release. IMHO for specification is even more important to stick to formal release than for ordinary library... There is no need to slow down development but release process needs to ensure that latest (formal, tagged) release of acbuild is based upon formal release of appc specification and other libraries.

@cgonyeo
Copy link
Member

cgonyeo commented Mar 23, 2016

acbuild should now be vendoring a tagged version of both rkt (v1.2.0) and the appc spec (v0.7.4), so I'm going to close this.

@cgonyeo cgonyeo closed this as completed Mar 23, 2016
@onlyjob
Copy link
Author

onlyjob commented Mar 23, 2016

Thanks. :)

@onlyjob
Copy link
Author

onlyjob commented Mar 23, 2016

Perhaps it would be a good time to tag new release of acbuild.

@cgonyeo
Copy link
Member

cgonyeo commented Mar 23, 2016

There's a few more things I'd like to get wrapped up before doing so. I've got a milestone for it:
https://github.com/appc/acbuild/milestones/v0.3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants