Windows CNI for overlay (vxlan) and host-gw (l2bridge) modes #85

rakelkar · 2017-11-01T14:58:47Z

This is an early PR to get feedback on a resolution to #80. Proposes changes to add CNI plugins for windows into the CNI repository. The plugins use the Windows Kernel Host Networking Service (HNS) APIs via the HCSSHIM package to configure an IP address on the windows network stack. Depends on #77.

TODO:

Add Unit Tests
Update Deps
Merge with dup logic in Support delegating to Windows CNI from Flannel CNI #76
Add Integration Tests

squeed · 2017-11-06T17:16:41Z

This seems pretty reasonable. One important thing - modules in pkg should have docblocks on all functions.

gkudra-msft · 2017-11-08T10:20:02Z

I like this. A couple of points:

To be clear, plugin-specific parameters are part of the top-level configuration (like ipMasq and endpointMacPrefix)?
The existing (private) wincni.exe binary would no longer exist. Instead, the unified code would be a part of this pkg/hns/* package. This is where code interpreting additionalArgs into HNS policy would go. Is the structure of the additionalArgs different than raw HNS policy, and if so, should there be docs for that?
A feature (or "capability") doesn't seem like it belongs in either of these. The Linux model for capabilities such as port mapping seems to have separate plugins. For Windows, it makes sense (to me) to put them into the hns package. Will they be implicitly applied when the plugin passes them along? My gut (and analysis of the code) says no; how, then, do we do that cleanly?

rakelkar · 2017-11-11T21:27:59Z

@gkudra-msft

endpointMacPrefix is not part of top-level configuration since l2bridge mode doesn't need it.
The current code already supports merging additionalArgs - the structure is identical.
I think portmapping is a chained plugin to enable all Linux plugins to use it. For windows it depends on whether policies can be set after the endpoint is created. If yes, makes sense to have a windows verson of portmap if no, then the right thing to do it to put helpers into pkg/hns and use while creating endpoints

madhanrm · 2017-12-16T01:28:44Z

will update the PR with review comments

madhanrm · 2017-12-16T02:34:06Z

Sample build output:
madhanm@NetAppLinux:~/repo/gopath/src/github.com/containernetworking/plugins$ bash build.sh
Building plugins
flannel
portmap
tuning
bridge
host-device
ipvlan
loopback
macvlan
ptp
vlan
l2bridge.exe
overlay.exe
dhcp
host-local
sample

madhanrm · 2017-12-16T09:04:16Z

Fixed the Windows CI test.

madhanrm · 2017-12-21T20:22:58Z

@squeed Can you look into this and get this merged? Is there any open items here?

rakelkar · 2017-12-21T21:20:35Z

@madhanrm see TODO in PR description. CNI maintainers asked for integration tests like other plugins.

madhanrm · 2017-12-21T21:26:55Z

@rakelkar Yes, that has to be done in a separate PR. This PR is already huge.

rakelkar · 2017-12-21T21:31:59Z

Maybe you want to do the vendor update in a separate PR... I am guessing that contributes most of the hugeness?

…

On Dec 21, 2017 1:26 PM, "Madhan Raj Mookkandy" ***@***.***> wrote: @rakelkar <https://github.com/rakelkar> Yes, that has to be done in a separate PR. This PR is already huge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#85 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADQphYFCtFfIBXGx1TxVTMuWkfTIwBCPks5tCs0ggaJpZM4QOUvB> .

madhanrm · 2018-01-02T23:35:59Z

Vendor changes are required to get the current windows Appveyor test running and passing. We should be adding the integration test separately, once we have the dependencies merged.

madhanrm · 2018-01-02T23:37:39Z

ping @rosenhouse , @squeed

rosenhouse · 2018-01-03T02:47:12Z

Sorry for the delay, most of us were/still-are on holiday.

Please squash and follow guidelines for commit message.

PatrickLang · 2018-01-31T23:58:00Z

@madhanrm - can you fix the travis break?

Is this just waiting on review or are there other issues blocking this from moving forward?

- containernetworking#85 - rakelkar@0049c64

Patch for containernetworking#85 + Windows cni plugins are added (*) hostgw (l2bridge) (*) vxlan (overlay) + Windows netconf unit test + Fix appveyor config to run the test + Build Release support for windows plugins

From: - containernetworking#85 - rakelkar@0049c64

benmoss · 2018-08-28T13:41:57Z

@thxCode opened a PR with fixes here: #193

From: - containernetworking#85 - rakelkar@0049c64

+ Windows cni plugins are added (*) hostgw (l2bridge) (*) vxlan (overlay) + Windows netconf unit test + Fix appveyor config to run the test + Build Release support for windows plugins Based on containernetworking#85 Co-authored-by: rakelkar <[email protected]> Co-authored-by: Madhan Raj Mookkandy <[email protected]>

From: - containernetworking#85 - rakelkar@0049c64

daschott · 2018-09-04T17:00:36Z

@rosenhouse @thxCode thank you for the insight and help for this PR. Are there any outstanding issues or actions needed to merge this initial PR in?

Patch for containernetworking#85 + Windows cni plugins are added (*) win-bridge (hostgw) (*) win-overlay (vxlan) + Windows netconf unit test + Fix appveyor config to run the test + Build release support for windows plugins Address comments From: - containernetworking#85 - rakelkar@0049c64

dcbw · 2018-09-20T20:17:19Z

Merged #193 as a continuation of this one.

Patch for containernetworking#85 + Windows cni plugins are added (*) win-bridge (hostgw) (*) win-overlay (vxlan) + Windows netconf unit test + Fix appveyor config to run the test + Build release support for windows plugins Address comments From: - containernetworking#85 - rakelkar@0049c64

Patch for containernetworking/plugins#85 + Windows cni plugins are added (*) win-bridge (hostgw) (*) win-overlay (vxlan) + Windows netconf unit test + Fix appveyor config to run the test + Build release support for windows plugins Address comments From: - containernetworking/plugins#85 - rakelkar/plugins@0049c64

This was referenced Nov 1, 2017

Add a CNI for Windows #80

Closed

Support delegating to Windows CNI from Flannel CNI #76

Closed

rakelkar force-pushed the windowsCni branch from 2eb38e0 to 60e21e9 Compare November 21, 2017 23:57

madhanrm force-pushed the windowsCni branch from 60e21e9 to 7fb11e6 Compare December 16, 2017 02:31

madhanrm force-pushed the windowsCni branch 5 times, most recently from ef5bf7e to ab985f5 Compare December 16, 2017 09:01

madhanrm force-pushed the windowsCni branch from ab985f5 to e0deeaf Compare December 16, 2017 09:42

madhanrm force-pushed the windowsCni branch 2 times, most recently from 24d79d4 to 7361f51 Compare January 4, 2018 20:57

dmitryzykov mentioned this pull request Jan 15, 2018

Support Windows in host-gw and VXLAN modes flannel-io/flannel#833

Closed

feiskyer mentioned this pull request Jan 29, 2018

Open Virutal Network/Open VSwitch is the only solution for kubernetes windows cluster? kubernetes/kubernetes#56751

Closed

rakelkar force-pushed the windowsCni branch from 80b085f to 1fc833a Compare February 4, 2018 07:15

dineshgovindasamy force-pushed the windowsCni branch from cf43942 to 07488ad Compare February 12, 2018 20:17

thxCode added a commit to thxCode/containernetworking-plugins that referenced this pull request Aug 23, 2018

Address some comments from

181aef7

- containernetworking#85 - rakelkar@0049c64

thxCode added a commit to thxCode/containernetworking-plugins that referenced this pull request Aug 23, 2018

Address some comments from

f8be4ce

- containernetworking#85 - rakelkar@0049c64

thxCode added a commit to thxCode/containernetworking-plugins that referenced this pull request Aug 23, 2018

Address some comments from

7dc47ba

- containernetworking#85 - rakelkar@0049c64

thxCode added a commit to thxCode/containernetworking-plugins that referenced this pull request Aug 23, 2018

Address comments

578b32b

From: - containernetworking#85 - rakelkar@0049c64

daschott mentioned this pull request Aug 28, 2018

host-gw: add windows support flannel-io/flannel#921

Closed

2 tasks

rosenhouse pushed a commit to rosenhouse/plugins that referenced this pull request Aug 29, 2018

Address comments

4d67285

From: - containernetworking#85 - rakelkar@0049c64

rosenhouse pushed a commit to rosenhouse/plugins that referenced this pull request Aug 29, 2018

Address code review comments on original Windows plugins

dc8794b

From: - containernetworking#85 - rakelkar@0049c64

rosenhouse pushed a commit to rosenhouse/plugins that referenced this pull request Aug 29, 2018

Address code review comments on original Windows plugins

d3490cd

From: - containernetworking#85 - rakelkar@0049c64

rosenhouse pushed a commit to rosenhouse/plugins that referenced this pull request Aug 29, 2018

Address comments on original Windows plugins PR

3a63ef7

From: - containernetworking#85 - rakelkar@0049c64

thxCode added a commit to thxCode/containernetworking-plugins that referenced this pull request Aug 30, 2018

Address comments

4a139eb

From: - containernetworking#85 - rakelkar@0049c64

thxCode added a commit to thxCode/containernetworking-plugins that referenced this pull request Aug 30, 2018

Address comments

a58362b

From: - containernetworking#85 - rakelkar@0049c64

thxCode added a commit to thxCode/containernetworking-plugins that referenced this pull request Aug 30, 2018

Address comments

4298921

From: - containernetworking#85 - rakelkar@0049c64

dcbw closed this Sep 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows CNI for overlay (vxlan) and host-gw (l2bridge) modes #85

Windows CNI for overlay (vxlan) and host-gw (l2bridge) modes #85

rakelkar commented Nov 1, 2017 •

edited

Loading

squeed commented Nov 6, 2017

gkudra-msft commented Nov 8, 2017

rakelkar commented Nov 11, 2017

madhanrm commented Dec 16, 2017

madhanrm commented Dec 16, 2017

madhanrm commented Dec 16, 2017

madhanrm commented Dec 21, 2017

rakelkar commented Dec 21, 2017

madhanrm commented Dec 21, 2017

rakelkar commented Dec 21, 2017 via email

madhanrm commented Jan 2, 2018

madhanrm commented Jan 2, 2018

rosenhouse commented Jan 3, 2018

PatrickLang commented Jan 31, 2018

benmoss commented Aug 28, 2018

daschott commented Sep 4, 2018

dcbw commented Sep 20, 2018

Windows CNI for overlay (vxlan) and host-gw (l2bridge) modes #85

Windows CNI for overlay (vxlan) and host-gw (l2bridge) modes #85

Conversation

rakelkar commented Nov 1, 2017 • edited Loading

squeed commented Nov 6, 2017

gkudra-msft commented Nov 8, 2017

rakelkar commented Nov 11, 2017

madhanrm commented Dec 16, 2017

madhanrm commented Dec 16, 2017

madhanrm commented Dec 16, 2017

madhanrm commented Dec 21, 2017

rakelkar commented Dec 21, 2017

madhanrm commented Dec 21, 2017

rakelkar commented Dec 21, 2017 via email

madhanrm commented Jan 2, 2018

madhanrm commented Jan 2, 2018

rosenhouse commented Jan 3, 2018

PatrickLang commented Jan 31, 2018

benmoss commented Aug 28, 2018

daschott commented Sep 4, 2018

dcbw commented Sep 20, 2018

rakelkar commented Nov 1, 2017 •

edited

Loading