Help using gRPC containerd-client, "namespace is required: failed precondition"

[mfernd]

Hello, I'm trying to use the grpc bindings from containerd-client.

And when I try to list containers in the namespace moby (I also tried with other namespaces I've created), I get an error about the namespace missing.

Here is a sample of my code:

#[tokio::main]
async fn main() -> anyhow::Result<()> {
    tracing_subscriber::fmt().with_max_level(Level::INFO).init();

    let channel = containerd_client::connect("/run/containerd/containerd.sock").await?;

    let mut client = ContainersClient::new(channel.clone());

    let req = ListContainersRequest::default();
    let req = with_namespace!(req, "moby");
    info!("{:?}", req);

    let container_list = client.list(req.into_inner()).await?;
    info!("{:?}", container_list.into_inner());

    Ok(())
}

Here is the tonic Request sended to containerd:

Request { metadata: MetadataMap { headers: {"containerd-namespace": "moby"} }, message: ListContainersRequest { filters: [] }, extensions: Extensions }

I have this error:

Error: status: FailedPrecondition, message: "namespace is required: failed precondition", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }

Versions

Here is my version of containerd (at least I can get this information from containerd):
VersionResponse { version: "1.6.21", revision: "3dce8eb055cbb6872793272b4f20ed16117344f8" }

And here is my dependencies from Cargo.toml

[dependencies]
anyhow = "1.0.72"
containerd-client = "0.3.0"
prost = "0.11.9"
prost-types = "0.11.9"
tokio = { version = "1.29.1", features = ["full"] }
tonic = "0.9.2"
tracing = "0.1.37"
tracing-subscriber = "0.3.17"

[build-dependencies]
tonic-build = "0.9.2"

Maybe I did something wrong somewhere, but I can't see where.
Hoping you could enlighten me.

[mxpv]

Hi. I was able to reproduce your example above.

Try this instead:

let container_list = tasks_client.list(req).await?;

req.into_inner() gets body, but looses headers, which is not what we want here.

[mfernd]

Thanks for the response.

Oh yeah the namespace is in the tonic request headers, so it makes sense that it's losing it.

But when I do this (I think it's what is written in the examples):

let container_list = client.list(req).await?;

I get this error at compile time:

the trait bound `tonic::Request<containerd_client::services::v1::ListContainersRequest>: containerd_client::tonic::IntoRequest<containerd_client::services::v1::ListContainersRequest>` is not satisfied
the trait `containerd_client::tonic::IntoRequest<T>` is implemented for `containerd_client::tonic::Request<T>`

[mfernd]

Okay I've tested with building on using direclty the git dependency:

containerd-client = { git = "https://github.com/containerd/rust-extensions", branch = "main" }

instead of:

containerd-client = "0.3.0"

And I no longer have this error on the line:

let container_list = client.list(req).await?;

So I think the problem comes from the version on crates.io which is not up to date anymore(?)

[mfernd]

@mxpv
You updated the tonic dependencies since 0.3.0 on git and the crates.io version is not up to date anymore, maybe a 0.3.1 should be uploaded?

[mxpv]

Will do: #175

[mxpv]

@lapsus-ord new client is out: https://github.com/containerd/rust-extensions/releases/tag/client-v0.4.0

[mfernd]

Thank you for your time 👍

[sailorvii]

Hit the same issue with version 0.4.0, but it's okay with version main.