Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt youki executors when upgrading libcontainer #209

Closed
0xE282B0 opened this issue Jul 27, 2023 · 6 comments
Closed

Adapt youki executors when upgrading libcontainer #209

0xE282B0 opened this issue Jul 27, 2023 · 6 comments
Assignees

Comments

@0xE282B0
Copy link
Contributor

0xE282B0 commented Jul 27, 2023

Youki has changed the way executors are created. The new method is to create a get_executor() function that returns an Executor. The executors in the youki crate can be used as an example: https://github.com/containers/youki/blob/main/crates/youki/src/workload
Instead of the can_handle() function, the executor now returns an ExecutorError::CantHandle(EXECUTOR_NAME) error, which is then handled explicitly like this https://github.com/containers/youki/blob/main/crates/youki/src/workload/executor.rs#L18-L23. This gives more control over the order in which executors are tried.

We need to adapt our executors before upgrading to latest libcontainer version.

@Mossaka Mossaka self-assigned this Jul 27, 2023
@Mossaka
Copy link
Member

Mossaka commented Jul 27, 2023

I can take this one when a new version of libcontainer is released

@utam0k
Copy link
Member

utam0k commented Jul 29, 2023

cc: @yihuaf 👀

@yihuaf
Copy link
Contributor

yihuaf commented Jul 29, 2023

@Mossaka Would you mind assign this to me so I can help take care of this? This is also a good exercise for me to understand the ergonomics of the libcontainer apis.

@Mossaka
Copy link
Member

Mossaka commented Jul 30, 2023

Sure!

@0xE282B0
Copy link
Contributor Author

@yihuaf runwasi now uses libcontainer 0.2. Is there anything else to do here, or can we close this issue?

@Mossaka
Copy link
Member

Mossaka commented Sep 15, 2023

Nope we can close it now

@Mossaka Mossaka closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants