-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt youki executors when upgrading libcontainer #209
Comments
I can take this one when a new version of |
cc: @yihuaf 👀 |
@Mossaka Would you mind assign this to me so I can help take care of this? This is also a good exercise for me to understand the ergonomics of the libcontainer apis. |
Sure! |
@yihuaf runwasi now uses libcontainer 0.2. Is there anything else to do here, or can we close this issue? |
Nope we can close it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Youki has changed the way executors are created. The new method is to create a
get_executor()
function that returns an Executor. The executors in the youki crate can be used as an example: https://github.com/containers/youki/blob/main/crates/youki/src/workloadInstead of the
can_handle()
function, the executor now returns anExecutorError::CantHandle(EXECUTOR_NAME)
error, which is then handled explicitly like this https://github.com/containers/youki/blob/main/crates/youki/src/workload/executor.rs#L18-L23. This gives more control over the order in which executors are tried.We need to adapt our executors before upgrading to latest libcontainer version.
The text was updated successfully, but these errors were encountered: