Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker run with wasmedge shim stop working #81 #163

Closed
1 task done
CaptainVincent opened this issue Jun 29, 2023 · 1 comment · Fixed by #168
Closed
1 task done

docker run with wasmedge shim stop working #81 #163

CaptainVincent opened this issue Jun 29, 2023 · 1 comment · Fixed by #168

Comments

@CaptainVincent
Copy link
Contributor

CaptainVincent commented Jun 29, 2023

Issue Highlight

docker run --rm --runtime=io.containerd.wasmedge.v1 --platform wasi/wasm jorgeprendes420/wasmtest echo 'hello'

Fail commit need run with wasmedge 0.12.1

git clone https://github.com/WasmEdge/wasmedge_hyper_demo.git
cd wasmedge_hyper_demo
docker compose up client

Fail commit need run with older wasmedge 0.11.2
[Update]
The shim now requires the entrypoint path to be resolved using normal posix executable resolution now.
so ENTRYPOINT need start with / is the new usage restrictions and add padding / in path could resolve the second one.

Motivation

Due to the plan of deprecating the fork under Second State, I need to conduct an evaluation of the current functionality of containerd/runwasi before proceeding. I have discovered that using the wasmedge runtime with Docker has been broken for quite some time (all testing while ctr is working fine). Here, I am providing a document that includes the codebase and process I have been using to test docker run.

@CaptainVincent CaptainVincent changed the title docker run with wasmedge shim stop working after #78 docker run with wasmedge shim stop working (suspected existence of multiple issues) Jul 5, 2023
@CaptainVincent CaptainVincent changed the title docker run with wasmedge shim stop working (suspected existence of multiple issues) docker run with wasmedge shim stop working #81 Jul 5, 2023
@jprendes
Copy link
Collaborator

jprendes commented Jul 5, 2023

I've identified the underlying issue in containerd-shim and created an upstream PR: containerd/rust-extensions#151
Once that's merged upstream we need to bump the containerd-shim dependency here. This will also require bumping the ttrpc dependency to 0.8.0.

We should also add a test to make sure we catch these kind of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants