Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance::new should return a Result type #158

Closed
Mossaka opened this issue Jun 23, 2023 · 1 comment · Fixed by #340
Closed

Instance::new should return a Result type #158

Mossaka opened this issue Jun 23, 2023 · 1 comment · Fixed by #340

Comments

@Mossaka
Copy link
Member

Mossaka commented Jun 23, 2023 

          This was discussed before: https://github.com/containerd/runwasi/pull/54#issuecomment-1403269766

IMHO we should aim to remove as many unwrap() calls as possible from shim "main thread", because a library should not panic easily.

Originally posted by @ipuustin in #142 (comment)
@cpuguy83
Copy link
Member

I seem to recall this causes issues with the type being unsized.

@jprendes jprendes mentioned this issue Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build libcontainer's container on Instance::new to be spec compliant jprendes/runwasi
2 participants
@cpuguy83 @Mossaka