Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump gingko to v2.19.1, golang to v1.21.x. #110

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

klihub
Copy link
Member

@klihub klihub commented Sep 25, 2024

Bump ginkgo version to v2.19.1. This should get us rid of coverage collection errors occasionally seen in CI. Bump minimum golang requirement to 1.21, which should be fine both for containerd (including the 1.7 branch) and cri-o.

Update ginkgo to v2.19.1. This should get us rid of the coverage
collection errors seen in CI.

Signed-off-by: Krisztian Litkey <[email protected]>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub
Copy link
Member Author

klihub commented Sep 25, 2024

LGTM

@mikebrow I split this out form #109, so it's easier to review and merge it piecemeal. I'll rebase #109 on top of this... and maybe I should mark it as draft before this gets merged, so we don't have partially overlapping PRs open ? WDYT ?

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 668be88 into containerd:main Sep 25, 2024
8 checks passed
@klihub klihub deleted the devel/bump-golang-and-ginkgo branch September 26, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants