Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ipfs binary from nerdctl-full #3532

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Remove ipfs binary from nerdctl-full #3532

merged 1 commit into from
Oct 14, 2024

Conversation

yankay
Copy link
Contributor

@yankay yankay commented Oct 12, 2024

Removing ipfs binary from nerdctl-full

fix #3527

@yankay yankay added the area/ipfs IPFS label Oct 12, 2024
@yankay yankay changed the title Removing ipfs binary from nerdctl-full Remove ipfs binary from nerdctl-full Oct 12, 2024
@apostasie
Copy link
Contributor

We need it for testing though.
We might want to start considering a more modular approach to this Dockerfile - and different targets for the published artifacts vs. the stuff we use for testing.

AkihiroSuda
AkihiroSuda reviewed Oct 12, 2024
View reviewed changes
Dockerfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KUBO_VERSION in L39-40 should be moved to the “Test deps” section (L46-52)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AkihiroSuda

It has been changed

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 12, 2024
AkihiroSuda
AkihiroSuda approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 62a8286 into containerd:main Oct 14, 2024
22 checks passed
@github-actions github-actions bot mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apostasie apostasie apostasie approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/ipfs IPFS impact/major
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Consider removing ipfs binary from nerdctl-full
3 participants
@yankay @apostasie @AkihiroSuda