Enable to propagate necessary information to snapshotter during unpack #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though containerd gives ChainID to backend snapshotters during unpack for searching snapshots to be skipped downloading the contents, ChainID isn't enough for some snapshotters which require additional information of layers. Some examples are remote snapshotters which is based on stargz filesystem (requires image-related information to query the contents to docker registry) and those which is based on CernVM-FS (requires manifest digest, etc. for providing squashed rootfs). This commit solves this issue by enabling a handler to inject additional information of layers to snapshotters during unpack. Signed-off-by: Kohei Tokunaga <[email protected]>
|
Build succeeded.
|
Codecov Report
@@ Coverage Diff @@
## master #3911 +/- ##
==========================================
- Coverage 42.47% 42.43% -0.04%
==========================================
Files 130 130
Lines 14716 14706 -10
==========================================
- Hits 6251 6241 -10
Misses 7544 7544
Partials 921 921
Continue to review full report at Codecov.
|
This was referenced Dec 23, 2019
mxpv
reviewed
Dec 24, 2019
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
Signed-off-by: Kohei Tokunaga <[email protected]>
|
Build succeeded.
|
|
LGTM @ktock thanks for the PR! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though containerd gives ChainID to backend snapshotters during unpack for
searching snapshots to be skipped downloading the contents, ChainID isn't enough
for some snapshotters which require additional information of layers.
Some examples are remote snapshotters which is based on stargz filesystem
(requires image-related information to query the contents to docker registry)
and those which is based on CernVM-FS (requires manifest digest, etc. for
providing squashed rootfs).
This commit solves this issue by enabling a handler to inject additional
information of layers to snapshotters during unpack.
Related discussion
You can test it on this remote snapshotter branch and the reproduction steps are here.
We need to discuss reasonable way to integrate handlers to containerd but I'm keeping it separated PR/issue.