Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: clarify expectations and reduce recommended size of volume ID #124

Closed
jdef opened this issue Oct 20, 2017 · 1 comment · Fixed by #132
Closed

spec: clarify expectations and reduce recommended size of volume ID #124

jdef opened this issue Oct 20, 2017 · 1 comment · Fixed by #132
Milestone

Comments

@jdef
Copy link
Member

jdef commented Oct 20, 2017

Volume IDs uniquely identify a volume. They should generally be human readable and useful for logging (debugging and tracing) purposes. The spec defines the type of id as string, which is fine. There's some debate around what the size of an ID should be.

This issue proposes that the CSI spec recommends a size limit of the protobuf-encoded volume id field to 256 bytes. Such a size provides ample space for uniqueness and also represents the upper length limit of a token that's useful w/ respect to logging and readability.

@jdef jdef added this to the v0.1 milestone Oct 20, 2017
@jdef
Copy link
Member Author

jdef commented Oct 20, 2017

PR #123 defines the length limit of an encoded volume ID as 1MiB, which I'd argue is MUCH too large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant