-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Witness API with MarshalBinary and MarshalJSON #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd binary serialization test coverage
ivokub
requested changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the examples it makes sense to require that witness is instantiated separately from the circuit. I haven't tried it out myself, but from the examples the proposed interface looks good.
There are a few comments, but mostly looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Main changes:
Previously:
backend/witness
package offered api likewitness.WriteFullTo(writer)
witness.ReadPublicFrom(reader)
...Now has a struct that implements
encoding/BinaryMarshaler
andencoding/json/Marshaler
. Essentially the witness can be in 3 different "state":frontend.Circuit
--> this is referred to an "assignment"[]fr.Element
--> this is represented underwitness.Witness
struct introduced by this PRwitness package enables to go from each of these states.
Other changes to validate approach:
backend/groth16
andbackend/plonk
hadReadAndProve
andReadAndVerify
methods. NowProve
andVerify
take awitness.Witness
as parameter. Puts more work on caller (can't pass afrontend.Circuiit
directly) but enables all workflow more cleanly.This PR might be significantly simplified if we add generics.
Added round trip marshaling test (binary & json) in the
test.Assert
call.Another PR should
IsSolved
(in backend/groth16 & backend/plonk) to take awitness.Witness
and to be defined, if possible directly on thefrontend.CompiledConstraintSystem
interface, since it's not directly dependent on the backend.