Add a count based sliding window breaker #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost91-
force-pushed
the
add-count-breaker
branch
2 times, most recently
from
c550217 to
65e82fc
Compare
ghost91-
force-pushed
the
add-count-breaker
branch
from
65e82fc to
2514ac7
Compare
|
@connor4312 thanks a lot for the quick review. I answered your comments, could you take a look at that? Depending on your opinion, I can make the suggested adjustments, of course. |
connor4312
approved these changes
Jul 17, 2024
|
@connor4312 Could you create a release with this change? Thanks in advance! |
|
I have a couple other changes I want to get in, I'm planning to do a release tonight or tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
CountBreaker, an additional implementation ofIBreakerthat implements a count based sliding window. It is inspired by the Count-based sliding window in Resilience4j.