Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for nanoporeBarcodeDirs doesn't work for S3 path #36

Open
lch14forever opened this issue Apr 23, 2020 · 3 comments
Open

Check for nanoporeBarcodeDirs doesn't work for S3 path #36

lch14forever opened this issue Apr 23, 2020 · 3 comments

Comments

@lch14forever
Copy link

Hi,

Thanks for developing this convenient pipeline. I am trying to run this on AWS batch but I found some problem in detecting the barcode option. Specifically I think this line only works for a local path:

def nanoporeBarcodeDirs = new FileNameByRegexFinder().getFileNames(params.basecalled_fastq, /.*barcode[0-9]{1,4}$/)

Do you have any suggestions? The only thing I can come up with is to add a flag param to let user specify whether barcodes were used.

Thanks in advance!

@m-bull
Copy link
Contributor

m-bull commented Apr 26, 2020

Hi @lch14forever - apologies for taking a while to get to this. Please could you test d31e8ef and see if it fixes your problem?

@lch14forever
Copy link
Author

Wow. That's a brilliant fix! I will try it out and let you know.

@lch14forever
Copy link
Author

Hi,

I think maybe the line for checking non-barcoded run should include compressed fastqs?

nanoporeNoBarcode = file("${params.basecalled_fastq}/*.fastq*", type: 'file', maxdepth: 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants