Start Composing Revelio #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willwill96
force-pushed
the
composing-revelio
branch
from
8424bcb to
23d9cc5
Compare
willwill96
commented
Mar 2, 2020
willwill96
commented
Mar 2, 2020
willwill96
commented
Mar 2, 2020
| "@types/ol": "^5.3.6", | ||
| "@types/react": "^16.9.5", | ||
| "@types/react-loadable": "^5.5.3", | ||
| "@typescript-eslint/parser": "^2.3.3", | ||
| "@typescript-eslint/parser": "^2.22.0", |
There was a problem hiding this comment.
needed to bump this version to support new typescript version
willwill96
commented
Mar 2, 2020
|
|
||
| type Props = React.HTMLProps<HTMLDivElement> & { | ||
| type Props = BoxProps & { |
There was a problem hiding this comment.
This errored with the new typescript version
willwill96
commented
Mar 2, 2020
willwill96
force-pushed
the
composing-revelio
branch
2 times, most recently
from
4d00b2a to
a806ec9
Compare
willwill96
commented
Mar 3, 2020
| "main": "src/main/webapp/main.js", | ||
| "license": "MIT", | ||
| "devDependencies": { | ||
| "@connexta/ace": "https://github.com/connexta/ace.git#81e7b8b22b3f7e43b356ba5dfbc065ffdb694892", | ||
| "@apollo/react-hooks": "^3.1.3", |
There was a problem hiding this comment.
Moved all dependencies to dev and peer dependencies so downstream project has to have the dependency. Maybe this is a bad idea?
There was a problem hiding this comment.
With these in dependencies the yarn.lock when importing downstream looks like this:
[email protected]:
+ version "1.0.47"
+ resolved "https://registry.yarnpkg.com/a-test-of-revelio/-/a-test-of-revelio-1.0.47.tgz#de3902a70813342fd9fe0f1434bc243bfd3f2362"
+ integrity sha512-MGhFVegnDCzTMp15AFL/vFSL/FiZnIqqDzrcF5pYsVeHqo/3E0az4Hl+JxZD8MyOWxQrkcSzg5al+cMOAgya0Q==
+ dependencies:
+ "@apollo/react-hooks" "^3.1.3"
+ "@apollo/react-ssr" "^3.1.3"
+ "@date-io/moment" "1.3.13"
+ "@material-ui/core" "^4.6.1"
+ "@material-ui/icons" "^4.2.1"
+ "@material-ui/lab" "^4.0.0-alpha.32"
+ "@material-ui/pickers" "^3.2.5"
+ a-test-of-revelio "^1.0.40"
+ abort-controller "^3.0.0"
+ apollo-cache-inmemory "^1.6.3"
+ apollo-client "^2.6.4"
+ apollo-link "^1.2.13"
+ apollo-link-batch-http "^1.2.13"
+ apollo-link-error "^1.1.12"
+ apollo-link-http "^1.5.16"
+ apollo-link-schema "^1.2.4"
+ apollo-server-express "^2.9.7"
+ compression "^1.7.4"
+ express "4.17.1"
+ geospatialdraw "0.5.5"
+ golden-layout "^1.5.9"
+ graphql "^14.5.8"
+ graphql-tag "^2.10.1"
+ graphql-tools "^4.0.5"
+ immutable "^4.0.0-rc.12"
+ lodash.throttle "^4.1.1"
+ moment "^2.24.0"
+ moment-timezone "^0.5.16"
+ ol "^6.0.1"
+ on-finished "^2.3.0"
+ polished "^3.4.1"
+ qs "^6.9.1"
+ react "^16.9.0"
+ react-dom "^16.9.0"
+ react-loadable "^5.5.0"
+ react-redux "^7.1.0"
+ react-router "^5.1.2"
+ react-router-dom "^5.1.2"
+ redux "^4.0.4"
+ redux-thunk "^2.3.0"
+ styled-components "^4.3.2"
+ universal-cookie "^4.0.2"
+ uuid "^3.3.3"
+ winston "^3.2.1"
+a-test-of-revelio@^1.0.40:
+ version "1.0.48"
+ resolved "https://registry.yarnpkg.com/a-test-of-revelio/-/a-test-of-revelio-1.0.48.tgz#178d3fd46b130288749329dd8fcca594da3793e6"
+ integrity sha512-08Tme3qmHN2XxERoL0IImio26ms0NwVWm5F97HNVsmSMorpQPz/cAf0uq/4ns6DyCN7zqfQOVVSNz8nOm0/Aow==
With them moved to peer/devDependencies:
+a-test-of-revelio@^1.0.49:
+ version "1.0.49"
+ resolved "https://registry.yarnpkg.com/a-test-of-revelio/-/a-test-of-revelio-1.0.49.tgz#054eb58e7758ba33c3ed734e041b2417d3d99360"
+ integrity sha512-3i5B+bIhTwClSyCs9NZs9bkgexIjlWhPnzr84hz4oyMFmBabaCXng5G7IzIOpbZ/Tvo+tRDdR8n6oMJo2Nhc1w==
willwill96
commented
Mar 3, 2020
| @@ -40,7 +40,7 @@ type QueryScheduleProps = { | |||
| } | |||
|
|
|||
| const DatePicker = (props: KeyboardDatePickerProps) => { | |||
| const [inputValue, setInputValue] = useState() | |||
| const [inputValue, setInputValue] = useState<string | undefined>() | |||
There was a problem hiding this comment.
This errored with new typescript version
bdeining
approved these changes
Mar 3, 2020
|
👍 I'll try this out on a downstream project and let you know if I run into any issues. |
willwill96
force-pushed
the
composing-revelio
branch
from
4875984 to
7109137
Compare
added 2 commits
March 10, 2020 07:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.