Add additional options for generating imports #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
smaye81
force-pushed
the
sayers/add_addl_opts
branch
from
f846001 to
f265a87
Compare
timostamm
reviewed
Dec 5, 2024
docs/node/getting-started.md
Outdated
Comment on lines
107
to
108
| # Also generate any well-known type dependencies | ||
| include_wkt: true |
There was a problem hiding this comment.
Can you give an example for why this is useful?
There was a problem hiding this comment.
Actually just realized we probably don't need that in the docs and should probably just use include_imports. Will update
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
smaye81
force-pushed
the
sayers/add_addl_opts
branch
from
57fac02 to
14a11ca
Compare
smaye81
changed the title
timostamm
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including imports is not enabled by default in the Buf CLI. As a result, users have been getting tripped up on generating code when they have dependencies on protovalidate.
This adds some additional guidance in our generating code docs to make sure they include imports since these should essentially always be included when generating with Protobuf-ES.