Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance: client does not return correct error code for 409 and 415 HTTP status codes #747

Closed
jhump opened this issue May 28, 2024 · 1 comment
Closed

conformance: client does not return correct error code for 409 and 415 HTTP status codes #747

jhump opened this issue May 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jhump
Copy link
Member

jhump commented May 28, 2024

The spec indicates that a 409 Conflict HTTP status code should be mapped to an aborted RPC error and 415 Unsupported Media Type should be mapped to an internal RPC error.

The client in this repo instead reports unknown RPC error for these cases.

Found by conformance tests in v1.14.0.
@jhump jhump added the bug Something isn't working label May 28, 2024
@jhump
Copy link
Member Author

jhump commented May 28, 2024

This bug was fixed by #673, and the fix was released in v1.15.0.

Also note that the specification was subsequently revised by RFC 003, which changed the mappings for these two and several other codes. Those changes were implemented in #706 and released in v1.16.0.

@jhump jhump closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhump