Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there plans to provide a standalone prometheus package that works with connect-go? #314

Closed
nomad-software opened this issue Jul 7, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@nomad-software
Copy link

nomad-software commented Jul 7, 2022

Is your feature request related to a problem? Please describe.
Nope. This isn't directly related to connect-go per se but to other packages made available by bufbuild.

I notice there is a standalone package to implement health checking so I wondered if there were plans to also release a Prometheus package that imitates https://github.com/grpc-ecosystem/go-grpc-prometheus but is created to work with connect-go?

Describe the solution you'd like
A drop-in solution similar to https://github.com/bufbuild/connect-grpchealth-go that mimics https://github.com/grpc-ecosystem/go-grpc-prometheus

Describe alternatives you've considered
I'd have to write one myself, which is fine but I wondered if you have plans for a more official package?

@nomad-software nomad-software added the enhancement New feature or request label Jul 7, 2022
@akshayjshah
Copy link
Member

We're planning to release a standalone OpenCensus integration, but not something that's Prometheus-specific. (If you're not familiar with it, OpenCensus is an abstraction over multiple metrics backends - it supports sending data to Prometheus, DataDog, statsd, Stackdriver, etc.) That package should be a good example for anyone who wants to integrate directly with a different metrics backend.

ETA is a few weeks; it's blocked on #296, which I'm actively working on.

@nomad-software
Copy link
Author

Great, thanks for the update.

@nomad-software
Copy link
Author

@akshayjshah Have you any more information on the release of the OpenCensus integration please?

@akshayjshah
Copy link
Member

Sorry! We're caught up with the upcoming connect-web release. We'll return to OC integration once that's done.

@akshayjshah
Copy link
Member

Sorry for the long periods of silence on this issue! Internally, we've decided to switch from OpenCensus to OpenTelemetry 😰 We're still not planning to write a first-party package that integrates directly with Prometheus. I'm going to close this issue in favor of #344 - if you're interested in ready-to-use observability interceptors, please subscribe to that issue instead.

@pqn
Copy link

pqn commented Jan 8, 2023

https://github.com/easyCZ/connect-go-prometheus may be relevant here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants