Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

removePackageByName() Should Use Transaction #64

Closed
confused-Techie opened this issue Nov 13, 2022 · 0 comments · Fixed by #68
Closed

removePackageByName() Should Use Transaction #64

confused-Techie opened this issue Nov 13, 2022 · 0 comments · Fixed by #68
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@confused-Techie
Copy link
Owner

removePackageByName() in database.js currently has a very ugly solution of running multiple commands and checking each for an error.

This should be upgraded into a proper transaction so things can rollback if something were to go wrong during the transaction.
@confused-Techie confused-Techie added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 13, 2022
@Digitalone1 Digitalone1 mentioned this issue Nov 15, 2022
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transaction for removePackageByName Digitalone1/atom-community-server-backend-JS
1 participant
@confused-Techie