Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename VALUE_AVRO_SCHEMA_FULL_NAME to VALUE_SCHEMA_FULL_NAME #4656

Closed
big-andy-coates opened this issue Feb 27, 2020 · 2 comments · Fixed by #8418
Closed

Rename VALUE_AVRO_SCHEMA_FULL_NAME to VALUE_SCHEMA_FULL_NAME #4656

big-andy-coates opened this issue Feb 27, 2020 · 2 comments · Fixed by #8418
Assignees
@lihaosky
Labels
pluggable-schemas schema-registry-integration streaming-engine Tickets owned by the ksqlDB Streaming Team user-experience

Comments

@big-andy-coates
Copy link
Contributor

Similar to #4556, this schema name should not be specific to AVRO, but also supported by PB.

At the moment generated PB schemas are pretty horrid with message names like ConnectDefault0 and ConnectDefault1 etc.

We ran into the same issue with Avro, which prompted the introduction of VALUE_AVRO_SCHEMA_FULL_NAME. Now we should make this more generic.
This was referenced Feb 27, 2020
Closed
Open
@big-andy-coates
Copy link
Contributor Author

Also see #4657

@big-andy-coates big-andy-coates mentioned this issue Feb 27, 2020
Merged
2 tasks
@colinhicks colinhicks mentioned this issue Jul 30, 2021
Closed
@mjsax mjsax assigned lihaosky and unassigned agavra Nov 23, 2021
@mjsax
Copy link
Member

mjsax commented Nov 23, 2021

Reassigning this ticket @lihaosky -- we need this for the schema-id work.

@mjsax mjsax added schema-registry-integration streaming-engine Tickets owned by the ksqlDB Streaming Team user-experience labels Nov 23, 2021
@lihaosky lihaosky linked a pull request Nov 29, 2021 that will close this issue
chore: add key/value schema name prop and refactor #8418
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lihaosky lihaosky

Labels
pluggable-schemas schema-registry-integration streaming-engine Tickets owned by the ksqlDB Streaming Team user-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add key/value schema name prop and refactor lihaosky/ksql
4 participants
@lihaosky @agavra @big-andy-coates @mjsax