Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error message inserting when no Schema Registry connectivity #4347

Closed
MichaelDrogalis opened this issue Jan 17, 2020 · 2 comments
Closed
Labels
Milestone

Comments

@MichaelDrogalis
Copy link
Contributor

Describe the bug

When inserting a record into a stream that's serialized with Avro, a poor error message is raised if ksqlDB can't connect to Schema Registry.

To Reproduce

With ksqlDB 0.6.0, where Schema Registry is not configured on the server:

CREATE STREAM s1 (c1 varchar) WITH (kafka_topic='t1', partitions=1, key='c1', value_format = 'avro');

insert into s1 (c1) values ('a');

Expected behavior

An error message indicating that ksqlDB couldn't connect to Schema Registry.

Actual behaviour

Failed to insert values into 'S1'. Could not serialize row: [ 'a' ]

This error message is tough because in a more complex setting, it leads the user to believe that it's a problem with their data.

@stevenpyzhang
Copy link
Member

@MichaelDrogalis this should be fixed with #4325
The error message should now say something like:

Caused by: KSQL is not configured to use a schema registry. To enable it, please
        set ksql.schema.registry.url

@MichaelDrogalis
Copy link
Contributor Author

@stevenpyzhang Nice one. Closing, staged for 0.7.

@MichaelDrogalis MichaelDrogalis added this to the 0.7.0 milestone Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants