Primitive Keys: Ensure create table gracefully handles null key in topic
#4109
Comments
apurvam
changed the title
null key in topicnull key in topic
|
Adding a null value in a change log causes QTT to blow up. |
|
A couple of questions:
|
|
@purplefox - CT is |
|
@big-andy-coates Hey Andy, could you add a little more info here please? |
purplefox
changed the title
null key in topicnull key in topic
|
It’s unclear how this could happen to me. If Hence, it seems you don't pass a |
|
+1 @mjsax looks like you're right. I've created a fix which makes the serialization/deserialization of null in ksql symmetrical (currently it's asymmetrical, i.e. serializing a null then deserializing doesn't get you back to null). This means the value passed to streams is null and the streams null checks work as intended. Fix is here. #4351 It seems to work, but I don't know if it's the best way to fix it, as most of this area of the code is new to me. @big-andy-coates wdyt? |
To recreate, add this test to
table.json:{ "name": "should not blow up on null key", "statements": [ "CREATE TABLE INPUT (ID bigint) WITH (kafka_topic='test_topic', value_format='DELIMITED');", "CREATE TABLE OUTPUT as SELECT * FROM INPUT;" ], "inputs": [ {"topic": "test_topic", "key": "1", "value": "1"}, {"topic": "test_topic", "key": null, "value": "2"}, {"topic": "test_topic", "key": "1", "value": "3"} ], "outputs": [ {"topic": "OUTPUT", "key": "1", "value": "1"}, {"topic": "OUTPUT", "key": "1", "value": "3"} ] }Results in NPE:
The text was updated successfully, but these errors were encountered: