From a434156aaf268239a163302da25283829bed7e44 Mon Sep 17 00:00:00 2001 From: rodesai Date: Wed, 21 Aug 2019 14:44:26 -0700 Subject: [PATCH] review feedback --- .../io/confluent/ksql/datagen/DataGen.java | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/ksql-examples/src/main/java/io/confluent/ksql/datagen/DataGen.java b/ksql-examples/src/main/java/io/confluent/ksql/datagen/DataGen.java index 12e13d208d8a..2f33ed6a7724 100644 --- a/ksql-examples/src/main/java/io/confluent/ksql/datagen/DataGen.java +++ b/ksql-examples/src/main/java/io/confluent/ksql/datagen/DataGen.java @@ -223,7 +223,7 @@ private static final class Builder { .put("schemaRegistryUrl", (builder, argVal) -> builder.schemaRegistryUrl = argVal) .put("propertiesFile", (builder, argVal) -> builder.propertiesFile = toFileInputStream(argVal).get()) - .put("msgRate", (builder, argVal) -> builder.msgRate = parseMsgRate(argVal)) + .put("msgRate", (builder, argVal) -> builder.msgRate = parseInt(argVal, 1)) .put("nThreads", (builder, argVal) -> builder.numThreads = parseNumThreads(argVal)) .put("printRows", (builder, argVal) -> builder.printRows = parsePrintRows(argVal)) .build(); @@ -470,22 +470,6 @@ private static int parseNumThreads(final String numThreadsString) { } } - private static int parseMsgRate(final String msgRateString) { - try { - final int result = Integer.valueOf(msgRateString, 10); - if (result < 0) { - throw new ArgumentParseException(String.format( - "Invalid msg rate in '%d'; must be a positive number", - result)); - } - return result; - } catch (NumberFormatException e) { - throw new ArgumentParseException(String.format( - "Invalid msg rate in '%s'; must be a positive number", - msgRateString)); - } - } - private static boolean parsePrintRows(final String printRowsString) { switch (printRowsString.toLowerCase()) { case "false": @@ -505,7 +489,7 @@ private static int parseInt(final String iterationsString, final int minValue) { final int result = Integer.valueOf(iterationsString, 10); if (result < minValue) { throw new ArgumentParseException(String.format( - "Invalid integer value '%d'; must be > %d", + "Invalid integer value '%d'; must be >= %d", result, minValue )); }