Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certificate generation #460

Open
wants to merge 1 commit into
base: 7.7.1-post
Choose a base branch
from
Open

Fix certificate generation #460

wants to merge 1 commit into from
+7 −7

Conversation

awattez
Copy link

@awattez awattez commented Dec 5, 2024

Description

Fix certificate generation reliability issues by:

  1. Adding xargs to handle MacOS wc command whitespace output
  2. Aligning return codes with shell conventions (0=success)
  3. Renaming check_num_certs to check_truststore_valid for clarity

Prevents unnecessary certificate regeneration on MacOS while maintaining Linux compatibility.

Author Validation

  • Run cp-demo successfully on MacOS 14.7.1
  • Verified certificate validation works correctly
  • Confirmed no unnecessary regeneration occurs
  • Tested backward compatibility on Linux

Reviewer Tasks

  • Run cp-demo to verify:
    • Certificate validation works
    • No unnecessary regeneration
    • Security features function correctly

@awattez awattez requested a review from a team as a code owner December 5, 2024 20:31
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@awattez awattez changed the base branch from 7.5.1-post to 7.7.1-post December 5, 2024 20:31
@awattez awattez linked an issue Dec 9, 2024 that may be closed by this pull request
Fix truststore certificate validation and improve function naming #459
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix truststore certificate validation and improve function naming
1 participant
@awattez