Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add governance proposal callback hooks #6

Closed
ethanfrey opened this issue Mar 8, 2021 · 2 comments · Fixed by #37
Closed

Add governance proposal callback hooks #6

ethanfrey opened this issue Mar 8, 2021 · 2 comments · Fixed by #37
Assignees
Labels
L Large task (4-10 days work)
Milestone

Comments

@ethanfrey
Copy link
Contributor

Support the new messages added in confio/tgrade-contracts#2

@ethanfrey ethanfrey added this to the Tgrade 0.1 milestone Mar 8, 2021
@ethanfrey ethanfrey modified the milestones: Tgrade 0.1, Tgrade 0.2 Mar 16, 2021
@ethanfrey ethanfrey added the L Large task (4-10 days work) label Mar 17, 2021
@alpe alpe self-assigned this May 4, 2021
@alpe
Copy link
Contributor

alpe commented May 5, 2021

I do understood this task that we want to handle any ExecuteGovProposal returned from a contract.

While implementing this though, the RawProtoProposal type opens the door for another interpretation or feature where a contract registers for a callback to receive this type from the gov handler.

@ethanfrey
Copy link
Contributor Author

While implementing this though, the RawProtoProposal type opens the door for another interpretation or feature where a contract registers for a callback to receive this type from the gov handler.

I don't understand the how this works? Is this a feature or a bug? What exactly could we do? I assume we can only call registered gov/proposal handlers and this RawProtoProposal only works to call a chain-specific gov proposal handler, which was not in our list. That said, this is only designed for tgrade, so maybe best to just remove that one and if we forgot something, add it as an explicit enum to the tgrade bindings

@alpe alpe closed this as completed in #37 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L Large task (4-10 days work)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants