cdh: move storage and secret crates into cdh modules #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
force-pushed
the
mkulke/rework-secret-and-storage-crates-as-cdh-modules
branch
2 times, most recently
from
17a6dfc to
761f99f
Compare
mkulke
force-pushed
the
mkulke/rework-secret-and-storage-crates-as-cdh-modules
branch
5 times, most recently
from
9d5a762 to
42bfebe
Compare
Xynnn007
approved these changes
Nov 20, 2024
the storage and secret crate is used exclusively by cdh, so we don't need to we don't need to maintain those as individual crates, helping with naming conflicts and reducing build complexity. the storage crate has a dep on the secret crate, so we have to cover them in a single change. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/rework-secret-and-storage-crates-as-cdh-modules
branch
from
42bfebe to
dc95b01
Compare
mkulke
deleted the
mkulke/rework-secret-and-storage-crates-as-cdh-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the storage and secret crate is used exclusively by cdh, so we don't need to we don't need to maintain those as individual crates, helping with naming conflicts and reducing build complexity.
the storage crate has a dep on the secret crate, so we have to cover them in a single change.