Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS #242

Open
fritzalder opened this issue May 14, 2024 · 3 comments
Open

CODEOWNERS #242

fritzalder opened this issue May 14, 2024 · 3 comments
Assignees
Labels

Comments

@fritzalder
Copy link
Member

The CODEOWNERS file still has issues. Since all the members in the file exist, I assume we simply do not have write access to this repository. Can one of the admins please double check and verify that we have write access?

At least I can confirm that I can also not approve PRs, so I assume that is why the CODEOWNERS file shows the warning for me.

Affected listed users seem to be:
@npmccallum @fritzalder @mssun @dirknono @cxzhang @dkaplan2

@riaankleinhans riaankleinhans self-assigned this May 14, 2024
@riaankleinhans
Copy link
Contributor

@fritzalder thank you for raising this.
I added repo access for everyone.
Once everyone accepted their invitations this issue could be closed

@fritzalder
Copy link
Member Author

I can confirm that I was now requested to review the most recent PR and am also removed from the CODEOWNERS error list.
So I would say once the CODEOWNERS lists no errors, we can just close this issue automatically.

@riaankleinhans
Copy link
Contributor

image

Invitations sent.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants