-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from Travis -> GH Actions and use Ameba #11
Conversation
@confact, here's an output sample from Ameba to get a feel for what I'd be changing if we add it to the repo:
|
@stephendolan, that's all fine. I know Ameba is starting to become standard in crystal, if not already. So go for it. Just happy that you want to spend time on this :) |
That sounds great, @confact. One other question since I'm far from a semantic versioning expert... Do you think this kind of refactor to satisfy Ameba is worth a version bump, or as long as all of the tests pass should we just leave the version alone? |
…ns while determining if it is an Ameba bug or not
Nevermind, I just realized that there's literally no point in cutting a release just for this CI and Ameba stuff :) I did end up opening crystal-ameba/ameba#194 since I think there's an issue with Ameba that's preventing this from passing. Once that issue is resolved, I'll submit a follow up PR to remove the |
… the nightly build! See https://discord.com/channels/591460182777790474/591597160492171264/801212734224990248 for more details around this change.
The nightly build will continue to fail until we figure out how to refactor This one just looks huge because I finally got |
@stephendolan this looks good to me, We can find some solution for the error later. It would be nice for everything to pass but let's also keep this small enough :) Great job with docs as well, just prove it is good with some new eyes and energy to look things through! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR tackles the following:
latest
andnightly
Crystal versions, allowingnightly
to fail as an "experimental" version.