Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests depend on already created workflows #117

Open
marcocrasso opened this issue Aug 12, 2022 · 0 comments
Open

Integration tests depend on already created workflows #117

marcocrasso opened this issue Aug 12, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@marcocrasso
Copy link
Contributor

marcocrasso commented Aug 12, 2022

There are two sets of integration tests, one for testing registration, the other execution. The registration test tries to register a workflow, which requires simple tasks and sub-workflow to be already registered. Furthermore, "override" doesn't work with community conductor server, thus the test requires to first unregister the workflow (if present). The other test has similar requirements.

How to reproduce the issue

git clone https://github.com/conductor-sdk/conductor-python
cd conductor-python
git checkout main
git pull 
docker run --name test-conductor-server --rm -d -p 8080:8080 ideaplexus/conductor-server:3.9.1 && echo "Waiting 10secs for Conductor Server to be ready..." && sleep 10
export PYTHON_INTEGRATION_TESTS_SERVER_API_URL=http://localhost:8080/api
export CONDUCTOR_PYTHON_VERSION=3.7
virtualenv conductor
source conductor/bin/activate
python3 setup.py install
python3 tests/integration.py
@marcocrasso marcocrasso changed the title Integration tests depends on already created workflows Integration tests depend on already created workflows Aug 12, 2022
@gardusig gardusig self-assigned this Sep 1, 2022
@gardusig gardusig added the enhancement New feature or request label Sep 1, 2022
@gardusig gardusig linked a pull request Sep 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants