Stop injecting installed channels that do not exist #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
2 tasks
|
Ready for review. Failures are from the new test_prune_* tests, which are dealt with in #270. |
kenodegard
previously requested changes
Sep 14, 2023
Co-authored-by: Ken Odegard <[email protected]>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
jezdez
changed the title
jezdez
reviewed
Sep 16, 2023
jaimergp
commented
Sep 18, 2023
| *in_state.maybe_free_channel(), | ||
| ) | ||
| ] | ||
| override = (getattr(context, "_argparse_args", None) or {}).get("override_channels") |
There was a problem hiding this comment.
I wonder if conda should have a context flag for override_channels. This is a bit clunky and, unless I am missing a good reason, unnecessary.
There was a problem hiding this comment.
agreed
I suspect the reasoning was because it would mean users could set it in their condarc and override channel settings set by sys admins
jaimergp
commented
Sep 18, 2023
|
Ehm, so I moved the tests to a different file and CI workflow to debug things a bit and it passes there. Definitely some kind of side-effect with other test in the upstream suite. Will deselect and we can move on. |
This was referenced Sep 20, 2023
jezdez
approved these changes
Sep 20, 2023
|
IMO this is good to go |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #262
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?