Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative logic for solver creation tasks #270

Merged
merged 52 commits into from
Sep 15, 2023
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Aug 28, 2023

Description

Same as #242 (closes #240) but trying other methods. We have reworked the "conda specs to libsolv tasks" logic to make use of libmamba.Solver.add_pin features now available in 1.5.1 to ensure we don't unnecessarily update packages.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 28, 2023
@jaimergp

This comment was marked as outdated.

@jezdez
Copy link
Member

jezdez commented Aug 29, 2023

@jaimergp I concur, this sounds like a good idea. We might be able to package libmamba 1.5.0 ahead of the release as well, of course, to retrofit testing on defaults as well.

@jaimergp
Copy link
Contributor Author

jaimergp commented Aug 29, 2023

Some good progress thanks to the pin fixes in main via mamba-org/mamba#2786. We will need a mamba 1.5.1 for that, so expect some failures here.

Note the flags we were using (see e40f0da) are not compatible with solver.add_pin, so I had to remove them (cc @AntoinePrv). Doesn't seem to make a difference so far in conda/conda's test_solve.py.

Let's see what the CI says! 👀

@jaimergp
Copy link
Contributor Author

jaimergp commented Aug 29, 2023

Ok, not bad, we are getting closer:

Upstream, 9 failures:

  • tests/cli/test_main_clean.py::test_clean_tempfiles - false positive due to flakiness
  • tests/cli/test_subcommands.py::test_create - weird networking error?
  • tests/cli/test_subcommands.py::test_env_create - weird networking error?
  • tests/core/test_solve.py::test_only_deps_2 - passes locally with dev libmamba
  • tests/test_create.py::test_install_features- passes on CI (libmamba 1.5.0) but breaks with proper Python pinning. Given it involves mkl features I am inclined to skip it, but 🤷
  • tests/test_create.py::test_package_pinning
  • tests/test_create.py::test_update_all_updates_pip_pkg
  • tests/test_export.py::test_explicit - need bugfix upstream (libmamba 1.5.1?)
  • tests/test_export.py::test_export - need bugfix upstream (libmamba 1.5.1?)

Unit, 3 failures:

  • tests/test_modified_upstream.py::PatchedCondaTestCreate::test_neutering_of_historic_specs - we fixed this to match conda/conda!
  • tests/test_modified_upstream.py::test_python2_update
  • tests/test_modified_upstream.py::test_update_all_1

@jaimergp
Copy link
Contributor Author

tests/test_misc.py::test_explicit_missing_cache_entries fails because PackageCacheData.get_all_extracted_entries()[0].url is None (on macOS only!). I can't reproduce locally, it's not solver-related, and it passes on other operating systems 🤷

@jaimergp jaimergp marked this pull request as ready for review September 13, 2023 21:26
@jaimergp jaimergp requested a review from jezdez September 13, 2023 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

installing libzlib in base results in libmamba updates
4 participants