-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improve stdlib-handling #5190
Comments
One question in particular is if conda-build wants to set defaults for the stdlib (as it does for the compilers already), and whether those match the naming of conda-forge.
Anaconda will similarly need to push the c-stdlib lower bounds on several key packages (e.g. macos 10.13 for anything related to abseil, protobuf, etc.), so presumably similar tools will be desirable. For example, Ray created an issue broadly related to this a long time ago, though here we're not talking about distributing the SDK, only having a metapackage that has a run-export on CC @jezdez @kenodegard @chenghlee @beeankha @mbargull PS. AFAIU, having a default is not necessary for conda-forge, so this decision could be deferred - we only need to detect the use of the stdlib jinja (in conjunction with the right CBC keys). My question arises mainly from looking at |
N.B.: "Write tests" should be the first or second, not last point here (assuming order)...
We should not add more channel-/package-specific defaults. I'll look into fixing the tests for that feature and a fix; should not take too long.. |
That's a completely fair assessment, but not something that was easy to tell just from looking at the current setup. 😅 Really appreciate you taking the time to write up a fix! |
Checklist
What is the idea?
#4999 added the
{{ stdlib("c") }}
function, and I'm working on rolling this out across conda-forge (chiefly in regro/cf-scripts#2135). However, I hit a road-block when I realized that smithy cannot rerender recipes using that new jinja function, in the sense that the configs for the respective CI jobs don't get the rightc_stdlib{,_version}
keys populated.This is apparently all coming from conda-build, and so we need to fix it here first.
Why is this needed?
Necessary to satisfy the goals of #4981, and be able to reflect the fact that many packages now have newer requirements on the C-stdlib than the long-running defaults currently still active in conda-forge (both on macos and soon linux too).
What should happen?
Additional Context
No response
The text was updated successfully, but these errors were encountered: