Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_conda_operation_locks call in environ.py wrong #4215

Closed
tholam opened this issue Mar 25, 2021 · 1 comment
Closed

get_conda_operation_locks call in environ.py wrong #4215

tholam opened this issue Mar 25, 2021 · 1 comment
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity

Comments

@tholam
Copy link

tholam commented Mar 25, 2021

Actual Behavior

conda_build.utils.get_conda_operation_locks had its signature updated some time ago but one of the calls to it wasn't updated to account for that

55eca10#diff-c54c378feea1d475af4a7c30e9be71e40de70f98c5e804e50e8c676569496f8aL326-R336

if not locks:
locks = utils.get_conda_operation_locks(config)
try:

Expected Behavior

I think the call should probably look something like this based on what's passed to the get_conda_operation_locks call in conda_build.environ.get_install_actions

locks = utils.get_conda_operation_locks(config.locking, tuple(config.bldpkgs_dirs), config.timeout)

I found this while trying to see if/how conda and conda build prevents race conditions in the package cache and am unsure if it actually causes any issues

@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label May 23, 2023
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Jun 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2023
@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Jun 23, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity
Projects
Archived in project
Development

No branches or pull requests

1 participant