Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondaStoreServer.log_level doesn't do anything #516

Closed
asmeurer opened this issue Aug 1, 2023 · 6 comments
Closed

CondaStoreServer.log_level doesn't do anything #516

asmeurer opened this issue Aug 1, 2023 · 6 comments
Assignees

Comments

@asmeurer
Copy link
Contributor

asmeurer commented Aug 1, 2023

CondaStoreServer.log_level nominally controls the logger level (see https://conda.store/en/latest/administration.html#conda-store-server-server-app-condastoreserver), but it's never actually used anywhere.

Furthermore, the log level is difficult to set at the command line because --CondaStoreServer.log_level=DEBUG doesn't work. You'd have to use --CondaStoreServer.log_level=10 (where logging.DEBUG == 10).

@trallard
Copy link
Collaborator

trallard commented Aug 3, 2023

If this is not used, and it is otherwise not adding anything in terms of user experience (CLI use) would it not be best to remove this altogether?

@pavithraes pavithraes added the type: question 🤔 Further information is requested label Aug 7, 2023
@pavithraes
Copy link
Member

@costrouc @pierrotsmnrd - What do you think about this?

@trallard trallard moved this from New 🚦 to TODO 📬 in conda-store 🐍 Aug 15, 2023
@trallard trallard moved this from TODO 📬 to Follow up 📤 in conda-store 🐍 Aug 18, 2023
@trallard
Copy link
Collaborator

@costrouc last ping here. Otherwise will just move ahead with removing this altogether.

@costrouc
Copy link
Member

I think this is a worthwhile issue to look into since this is the primary way that we debug things within a kubernetes deployment on nebari. I'd also say logging/printing in conda-store-server/worker(s) is inconsistent and needs clean up. Traitlets does provide a log attribute to LoggingConfigurable classes but it is not always accessible where you need.

@trallard trallard moved this from Follow up 📤 to Ready 🛎️ in conda-store 🐍 Aug 25, 2023
@trallard
Copy link
Collaborator

@nkaretnikov can you please take on this issue?

@trallard trallard added this to the challenges: Round 2 🚀 milestone Mar 20, 2024
@nkaretnikov nkaretnikov moved this from Ready 🛎️ to TODO 📬 in conda-store 🐍 Mar 20, 2024
@nkaretnikov nkaretnikov moved this from TODO 📬 to In Progress 🏗 in conda-store 🐍 Mar 20, 2024
@trallard trallard removed this from the challenges: Round 2 🚀 milestone Apr 30, 2024
@soapy1 soapy1 self-assigned this Oct 31, 2024
@peytondmurray
Copy link
Contributor

Closed by #940.

@github-project-automation github-project-automation bot moved this from In Progress 🏗 to Done 💪🏾 in conda-store 🐍 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

7 participants