Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builds should be able to be ordered by dates (scheduled_on, started_on, ended_on) #351

Closed
pierrotsmnrd opened this issue Jul 15, 2022 · 1 comment · Fixed by #352
Closed

Builds should be able to be ordered by dates (scheduled_on, started_on, ended_on) #351

pierrotsmnrd opened this issue Jul 15, 2022 · 1 comment · Fixed by #352
Assignees
@pierrotsmnrd
Labels
good first issue Good for newcomers type: enhancement 💅🏼

Comments

@pierrotsmnrd
Copy link
Contributor

Currently the build endpoint allows only sorting by id.
@pierrotsmnrd pierrotsmnrd self-assigned this Jul 15, 2022
@pierrotsmnrd pierrotsmnrd moved this to In Progress in Conda Store UI V1 Jul 15, 2022
@pierrotsmnrd pierrotsmnrd mentioned this issue Jul 15, 2022
Merged
@pierrotsmnrd pierrotsmnrd moved this from In Progress to In Review in Conda Store UI V1 Jul 15, 2022
@costrouc costrouc added the good first issue Good for newcomers label Jul 16, 2022
@costrouc
Copy link
Member

The following need to be modified in order for this to be possible https://github.com/Quansight/conda-store/blob/main/conda-store-server/conda_store_server/server/views/api.py#L546-L550.

As a bonus it would be nice to ensure that the fastapi docs reflect the available options (this would make the issue harder but not necissary).

Repository owner moved this from In Review to Done in Conda Store UI V1 Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierrotsmnrd pierrotsmnrd

Labels
good first issue Good for newcomers type: enhancement 💅🏼
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 351 : sort builds by start/scheduled/end dt conda-incubator/conda-store
2 participants
@pierrotsmnrd @costrouc