Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint failure #402

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Fix eslint failure #402

merged 3 commits into from
Jun 4, 2024

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented May 24, 2024

Fixes eslint failure. The failure message suggested to fix it with --fix so that is what's been done here.

Description

This pull request:

  • fixes linting failure

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@kcpevey kcpevey marked this pull request as ready for review May 24, 2024 19:50
@kcpevey kcpevey requested a review from gabalafou May 24, 2024 19:50
@trallard trallard merged commit 002259b into main Jun 4, 2024
4 checks passed
@trallard trallard deleted the fix_eslint_ci_failure branch June 4, 2024 15:24
gabalafou pushed a commit to gabalafou/conda-store-ui that referenced this pull request Jul 9, 2024
@kcpevey @gabalafou
Fix eslint failure (conda-incubator#402)
3ba2f6f 
* autofix by eslint

* switch to testing version spec change on rich instead of ipykernel

* select version number instead of operator for rich
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard approved these changes

@gabalafou gabalafou Awaiting requested review from gabalafou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcpevey @trallard