-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update conda-store-ui to new default port #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcmcand I've left some comments regarding unrelated changes. Please ping again once those are resolved and I'll test locally. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcmcand LGTM!
Tested with (was able to log in/out and build an env):
# server
python -m conda_store_server.server --standalone --config config.py
# ui
yarn run start
config.py:
# This MUST start with `/`
c.CondaStoreServer.url_prefix = "/conda-store"
server: 0760fa2
ui: cf6a34f8b9a44f6c10c9466ac423852373d52168, base: b4a5b46732f3441084fff4ff5537d494f0f3f09e
The config won't be necessary once conda-incubator/conda-store#647 lands.
Fixes #322
Description
Updates the default conda-store-ui port to be compatible with new conda-store-server default port. Although conda-store-server is configurable which port it runs on, and webpack will increment the port if 8080 isn't free, this PR removes the inherent conflict in ports. It also stops conda-store-server from running on port 5000 which is problematic for Mac users.
This pull request:
webpack.config.js
Pull request checklist
Additional information