Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conda-store-ui to new default port #324

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Oct 30, 2023

Fixes #322

Description

Updates the default conda-store-ui port to be compatible with new conda-store-server default port. Although conda-store-server is configurable which port it runs on, and webpack will increment the port if 8080 isn't free, this PR removes the inherent conflict in ports. It also stops conda-store-server from running on port 5000 which is problematic for Mac users.

This pull request:

  • Set default conda-store-ui port to port 8000
  • Update conda-store-server use to use new default port of 8080
  • Define port for conda-store-ui to run on in webpack.config.js

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcmcand I've left some comments regarding unrelated changes. Please ping again once those are resolved and I'll test locally. Thanks!

@dcmcand dcmcand requested a review from nkaretnikov October 31, 2023 12:56
Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcmcand LGTM!

Tested with (was able to log in/out and build an env):

# server
python -m conda_store_server.server --standalone --config config.py

# ui
yarn run start 

config.py:

# This MUST start with `/`
c.CondaStoreServer.url_prefix = "/conda-store"
server: 0760fa2
ui: cf6a34f8b9a44f6c10c9466ac423852373d52168, base: b4a5b46732f3441084fff4ff5537d494f0f3f09e

The config won't be necessary once conda-incubator/conda-store#647 lands.

@nkaretnikov nkaretnikov merged commit 646c583 into main Nov 3, 2023
@trallard trallard deleted the dcmcandrew-update-port branch December 21, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Update port for conda-store-server
2 participants