-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limiting compatibility with numpy 2.1 #116
Comments
looks like the reason we don't see that in CI (except upstream-dev) is that a dependency already pins to |
hmmm, i'm not sure how my previous environments were working with numpy 2.1 + xarray I tried:
and its not resolving.... so maybe something changed.... |
Hmm, i just created a fresh envrionment and I noticed my monkeypatching code (that fixex the issue referenced) got triggered (i print a warning).
seems to be compatible....
i don't know why i couldn't do this before |
Comment:
Is it worth limiting compatibility with numpy 2.1?
On my personal package, I already limit to numpy 1.X so I don't hit it so much, but I feel like some others might be hitting
pydata/xarray#9403
We personally hit it and added monkey patches around it....
The text was updated successfully, but these errors were encountered: