Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin libboost-headers #340

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Pin libboost-headers #340

merged 6 commits into from
Aug 27, 2024

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Aug 25, 2024 •
edited by Tobias-Fischer
Loading

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #339.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

Fixes #339

@conda-forge-webservices conda-forge-webservices bot mentioned this pull request Aug 25, 2024
Closed
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@Tobias-Fischer Tobias-Fischer changed the title MNT: rerender Pin libboost-headers Aug 25, 2024
@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please rerender

@Tobias-Fischer Tobias-Fischer marked this pull request as draft August 26, 2024 00:03
@Tobias-Fischer
Copy link
Contributor

Hi @hmaarrfk - it seems like the libboost-headers pin hasn't been picked up yet. Does it take a while?

@hmaarrfk
Copy link
Contributor

I think the pinning are broken. They aren't publishing.

@Tobias-Fischer
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

you may want to add a constraint for the libboost headers??? not too sure.

@Tobias-Fischer
Copy link
Contributor

I’m not sure I know what you mean by constraint?

@hmaarrfk
Copy link
Contributor

The bot will now 'rebuild' things, but it won't force this build of vtk to be paired with the same version of libboost_headers.

you might want to add:

run_constrained:
  - {{ pin_compatible('libboost_headers', max_pin='x.x') }}

@Tobias-Fischer Tobias-Fischer marked this pull request as ready for review August 26, 2024 03:27
@Tobias-Fischer
Copy link
Contributor

@conda-forge/vtk - if you have any comments, please let me know. Otherwise will merge in ~72 hours.

@Tobias-Fischer Tobias-Fischer mentioned this pull request Aug 26, 2024
Closed
@Tobias-Fischer Tobias-Fischer merged commit fd3159b into conda-forge:main Aug 27, 2024
72 checks passed
@Tobias-Fischer Tobias-Fischer mentioned this pull request Aug 28, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxyme Maxyme Awaiting requested review from Maxyme Maxyme is a code owner

@Tobias-Fischer Tobias-Fischer Awaiting requested review from Tobias-Fischer Tobias-Fischer is a code owner

@basnijholt basnijholt Awaiting requested review from basnijholt basnijholt is a code owner

@ccordoba12 ccordoba12 Awaiting requested review from ccordoba12 ccordoba12 is a code owner

@dfroger dfroger Awaiting requested review from dfroger dfroger is a code owner

@downiec downiec Awaiting requested review from downiec downiec is a code owner

@grlee77 grlee77 Awaiting requested review from grlee77 grlee77 is a code owner

@jasonb5 jasonb5 Awaiting requested review from jasonb5 jasonb5 is a code owner

@marcelotrevisani marcelotrevisani Awaiting requested review from marcelotrevisani marcelotrevisani is a code owner

@matthiasdiener matthiasdiener Awaiting requested review from matthiasdiener matthiasdiener is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@patricksnape patricksnape Awaiting requested review from patricksnape patricksnape is a code owner

@tadeu tadeu Awaiting requested review from tadeu tadeu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
3 participants
@conda-forge-admin @Tobias-Fischer @hmaarrfk