Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for stack_data, executing, and pure_eval #10492

Merged
merged 3 commits into from
Dec 25, 2019

Conversation

alexmojaki
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

Merry Christmas! 🎄

I'm submitting these packages so that they can eventually be dependencies of IPython once ipython/ipython#11886 is merged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/executing, recipes/pure_eval, recipes/stack_data) and found it was in an excellent condition.

@alexmojaki
Copy link
Contributor Author

Thanks, didn't know about noarch.

@npavlovikj npavlovikj merged commit fd07513 into conda-forge:master Dec 25, 2019
@npavlovikj
Copy link
Contributor

Thank you for the prompt fixes and contributing @alexmojaki 🎉

@alexmojaki
Copy link
Contributor Author

And thank you for the prompt merge :)

I'm looking at the feedstocks now. stack_data has a couple of commits, but the build failed because it can't find it's dependencies pure_eval and executing. But the new feedstocks for those two have zero commits in them, so of course they aren't available. Is it just a matter of waiting some more? Or is the failed build somehow holding the others up?

@npavlovikj
Copy link
Contributor

@alexmojaki , can you please submit another PR with the recipe for executing only? As you know, the feedstock for executing has not been created yet. I checked with the core team, and it looks like travis-ci has an issue and can only convert one feedstock in an hour.
Since you have 3 recipes in this PR, I am worried that if I just re-run the build, we will have the same issue. Thus, opening another PR just with executing should be the best workaround.
Please use the same recipe as here, and feel free to ping me to look at it once it is done.

@npavlovikj
Copy link
Contributor

@alexmojaki , sorry for the bother - I just saw that the feedstock for executing has been generated, so someone from the core team must have pushed the magic button :)
So, please ignore my previous comment.

@alexmojaki
Copy link
Contributor Author

Great, thanks for everything! All 3 packages seem to be properly in conda-forge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants