-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location of headers and binaries #1
Comments
cc @eddelbuettel it seems that the Debian packages for rcpp & co have the same issue Is there a means
|
Unsubscribing here as I have nothing to do with Conda (apart from occassionally seeing its users struggling with our normal R packages) and not enough bandwidth to get involved pro bono. If there are genuine upstream issues with R packages of mine feel free to bring them to their respective trackers. |
Well, the question was about rcpp and about the way you package it for Debian. |
afraid I'm not too familiar with conda. As for RcppArmadillo, it does indeed "vendor" armadillo headers in inst, but iirc there's also a few extra bits and pieces there as well. The reason for vendoring was to make it easy to offer RcppArmadillo on various platforms that R supports, which all have their ways to express dependencies .. |
What I have done for xtensor-r is make it a regular C++ package. There is a cmake target called
or
I wonder if I missed something before I make the first release. |
It might be interesting to write an article/blog post about this approach. As long as your generated You may want to also try |
Yes, it does, it is part of the CI (linux, mac and windows). Also, this allows me to not add the headers generated by Rcpp to the repository. It is a good idea, for the blog post... |
I get your point, we sort of live with pushing the code Rcpp (and e.g. roxygen) generates. This has pros and cons, but again, the ability for users to just simply |
I am opening the issue here but it applies to all three conda packages
rcpp
,rcpp-eigen
andrcpp-armadillo
.The issue with the way the conda packages are installed is that it makes use of the CRAN packages, which I think is bad practice. For example, the CRAN package for rcpp-armadillo vendors the armadillo headers in a subdirectory of
inst
, instead of depending of the Armadillo conda package.Instead, the headers and binaries for rcpp, rcpp-eigen, and rcpp-armadillo, should fall in their natural locations under the conda installation prefix, and the headers for dependencies Eigen and Amadillo should not be vendored in the conda package.
The text was updated successfully, but these errors were encountered: