Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH newer OSX SDKs #69

Merged
merged 4 commits into from
Nov 12, 2019
Merged

ENH newer OSX SDKs #69

merged 4 commits into from
Nov 12, 2019

Conversation

beckermr
Copy link
Member

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Relates to conda-forge/conda-forge.github.io#891

@beckermr
Copy link
Member Author

beckermr commented Nov 12, 2019

@conda-forge-admin, please rerender.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr
Copy link
Member Author

@conda-forge/pyqt any thoughts on the failure here?

@isuruf isuruf merged commit a0bf2cf into conda-forge:master Nov 12, 2019
skip: true # [ppc64le]
run_exports:
{{ pin_subpackage('pyqt', max_pin='x.x') }}

requirements:
run_constrained: # [osx]
- __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.9") }} # [osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is this straightforward to standardize, is there a way to move this into something like conda-forge-pinning?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I could think of unless we change the condition to be run instead of run_constrained which forces the user to use conda>=4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants